lukasz-antoniak commented on code in PR #336:
URL: https://github.com/apache/cassandra-sidecar/pull/336#discussion_r3091493335
##########
integration-framework/src/main/java/org/apache/cassandra/testing/TlsTestUtils.java:
##########
@@ -136,31 +123,32 @@ public static void waitForExistingRoles(Runnable runnable)
}
}
- public static SslContext buildSSLContext(String keystorePath, String
keystorePassword,
+ public static SSLContext buildSSLContext(String keystorePath, String
keystorePassword,
String trustStorePath, String
trustStorePassword) throws GeneralSecurityException, IOException
{
- SslContextBuilder sslContextBuilder;
+ SSLContext sslContext;
try
{
- sslContextBuilder = SslContextBuilder.forClient()
- .protocols(List.of("TLSv1.2",
"TLSv1.3"));
+ sslContext = SSLContext.getInstance("TLS");
Review Comment:
Allowing any TLS version enabled in JVM configuration. To explicitly
hardcode support for only TLS 1.2 and 1.3 versions, we would need to change it
on socket level with: `sslSocket.setEnabledProtocols(new String[] {"TLSv1.2",
"TLSv1.3"});`. This requires implementing custom driver `SslEngineFactory`.
Left it like this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
