smiklosovic commented on code in PR #4703:
URL: https://github.com/apache/cassandra/pull/4703#discussion_r3051925844
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -4369,12 +4369,14 @@ public void updateSnitch(String epSnitchClassName,
Boolean dynamic, Integer dyna
{
Supplier<NodeProximity> factory = () -> new
SnitchAdapter(DatabaseDescriptor.createEndpointSnitch(epSnitchClassName));
updateProximityInternal(factory, dynamic, dynamicUpdateInterval,
dynamicResetInterval, dynamicBadnessThreshold);
+ DatabaseDescriptor.setEndpointSnitch(epSnitchClassName);
Review Comment:
I would probably moved this inside `updateProximityInternal` and updated it
there, so that method updates everything. `epSnitchClassName` would be just
another parameter to `updateProximityInternal`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
