sedulam opened a new pull request, #4703: URL: https://github.com/apache/cassandra/pull/4703
## Summary Several JMX methods updated runtime state but never wrote back to the Config object, causing the Settings Virtual Table (`system_views.settings`) to show stale values after runtime changes. **Properties fixed:** - `endpoint_snitch` — `updateSnitch()` now updates `conf.endpoint_snitch` - `node_proximity` — `updateNodeProximity()` now updates `conf.node_proximity` - `dynamic_snitch` — `updateProximityInternal()` now updates `conf.dynamic_snitch` when the dynamic parameter is explicitly provided - `audit_logging_options` — `enableAuditLog()`/`disableAuditLog()` now update `conf.audit_logging_options` - `full_query_logging_options` — `enableFullQueryLogger()` now updates `conf.full_query_logging_options` Full audit of all 144 properties from the ticket attached as `CASSANDRA-17736-audit.md`. Of the 144 properties, 45 are correctly aligned, 88 have no JMX setter, 5 no longer exist on trunk, and 4 were misaligned (fixed in this patch). 2 properties from the original list (`table_count_warn_threshold`, `keyspace_count_warn_threshold`) are no longer in Config.java on trunk. ## Test plan - [x] `testAuditLogJmxUpdatesConfig` — verifies `enableAuditLog()` / `disableAuditLog()` update Config - [x] `testSnitchSettersUpdateConfig` — verifies `setDynamicSnitch()` and `setEndpointSnitch()` update Config - [x] `testEnableFullQueryLoggerUpdatesConfig` — verifies `enableFullQueryLogger()` updates Config - [x] All new tests fail on unfixed trunk (confirmed) and pass with the fix - [x] Existing tests pass: StorageServiceServerTest, FullQueryLoggerTest, SettingsTableTest - [x] Checkstyle passes (main and test) Patch by Pedro Gordo for CASSANDRA-17736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
