maedhroz commented on code in PR #4696:
URL: https://github.com/apache/cassandra/pull/4696#discussion_r3019775723
##########
test/distributed/org/apache/cassandra/distributed/test/sai/PartialUpdateHandlingTest.java:
##########
@@ -236,7 +236,11 @@ public void writeRepairedRows()
CLUSTER.coordinator(1).execute(insert.toString(),
ConsistencyLevel.ALL);
}
- CLUSTER.get(1).nodetoolResult("repair",
specification.keyspaceName()).asserts().success();
+ // Background reconciliation doesn't exist/work so incremental
repair just hangs waiting for reconciliation that never occurs
+ if (specification.replicationType.isTracked())
+ CLUSTER.get(1).nodetoolResult("repair", "-full",
specification.keyspaceName()).asserts().success();
Review Comment:
Anyway, I think the lack of background reconciliation still means that this
won't work. The transfer IDs are only there to make sure read reconciliation
works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
