maedhroz commented on code in PR #4696:
URL: https://github.com/apache/cassandra/pull/4696#discussion_r3019767467


##########
test/distributed/org/apache/cassandra/distributed/test/sai/PartialUpdateHandlingTest.java:
##########
@@ -236,7 +236,11 @@ public void writeRepairedRows()
                 CLUSTER.coordinator(1).execute(insert.toString(), 
ConsistencyLevel.ALL);
             }
 
-            CLUSTER.get(1).nodetoolResult("repair", 
specification.keyspaceName()).asserts().success();
+            // Background reconciliation doesn't exist/work so incremental 
repair just hangs waiting for reconciliation that never occurs
+            if (specification.replicationType.isTracked())
+                CLUSTER.get(1).nodetoolResult("repair", "-full", 
specification.keyspaceName()).asserts().success();

Review Comment:
   ```
   "node1_Repair#4:1" #270 daemon prio=5 os_prio=31 cpu=0.08ms elapsed=92.27s 
tid=0x000000013de75200 nid=0x2530b waiting on condition  [0x000000036944a000]
      java.lang.Thread.State: TIMED_WAITING (parking)
        at jdk.internal.misc.Unsafe.park([email protected]/Native Method)
        at 
java.util.concurrent.locks.LockSupport.parkNanos([email protected]/LockSupport.java:357)
        at 
org.apache.cassandra.utils.concurrent.AsyncFuture.awaitUntil(AsyncFuture.java:221)
        at 
org.apache.cassandra.utils.concurrent.Awaitable$Defaults.await(Awaitable.java:114)
        at 
org.apache.cassandra.utils.concurrent.AbstractFuture.await(AbstractFuture.java:482)
        at 
org.apache.cassandra.utils.concurrent.AbstractFuture.get(AbstractFuture.java:252)
        at 
org.apache.cassandra.replication.MutationTrackingSyncCoordinator.awaitCompletion(MutationTrackingSyncCoordinator.java:351)
        at 
org.apache.cassandra.repair.MutationTrackingIncrementalRepairTask.waitForSyncCompletion(MutationTrackingIncrementalRepairTask.java:127)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to