maedhroz commented on code in PR #4222:
URL: https://github.com/apache/cassandra/pull/4222#discussion_r3011068375
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -621,11 +624,10 @@ nowTs, filter(set, factory.regularColumns),
}
private enum DeleteKind
- {PARTITION, ROW, COLUMN}
+ {PARTITION, ROW, COLUMN, RANGE}
private void update(Mutation.Delete delete)
{
long nowTs = delete.timestampOrDefault(numMutations);
- //TODO (coverage): range deletes
var split = splitOnPartition(delete.where.simplify());
List<Clustering<ByteBuffer>> pks = split.left;
List<Clustering<ByteBuffer>> clusterings = split.right.isEmpty() ?
Collections.emptyList() : clustering(split.right);
Review Comment:
More a note than a real problem, but I think `clusterings` is not actually
used in any capacity in the `RANGE` case. Not sure yet if that means we want to
change the structure of this, but we probably could avoid the call to
`clustering()` (and maybe throw an assertion in there for the `RANGE` case
below to make sure `clusterings` is actually an empty list).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
