maedhroz commented on code in PR #4222:
URL: https://github.com/apache/cassandra/pull/4222#discussion_r3010995039
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -671,6 +675,20 @@ else if (!clusterings.isEmpty())
}
}
break;
+ case RANGE:
+ LookupContext ctx = new LookupContext(delete);
+ for (BytesPartitionState.Row value : partition.rows())
+ {
+ if (ctx.include(value))
+ {
+ partition.deleteRow(value.clustering, nowTs);
+ if (partition.shouldDelete())
+ partitions.remove(partition.ref());
+ }
+ }
+ if (partition.shouldDelete())
+ partitions.remove(partition.ref());
Review Comment:
If we check/remove after every row delete inside the loop, do we need to
check/remove again here after the loop? Can the state change aside from the
`deleteRow()` calls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
