jaydeepkumar1984 commented on PR #4644: URL: https://github.com/apache/cassandra/pull/4644#issuecomment-4150777996
> 👍 this seems to work great now, thanks! > > I think one thing we may just need to accept is that since the HostIds change between upgrade that existing repair history may be invalidated on upgrade to 6.0, which will provoke more repairs initially after the upgrade completes on all nodes, and the existing repair history will be eventually purged. > > Functionally this may be ok, it'd be equivalent to turning AutoRepair on for the first time, but maybe less impactful because data had been previously actively repaired. @jaydeepkumar1984 curious what you think about this? I think we can maybe add something in CHANGES.txt, but not sure what else we can do here as repair history used hostid as the key and i'm not sure how we can resolve the previous host id. If NodeIds change, the repair order won't be preserved. By default, AutoRepair picks older nodes that have undergone repair. But it still goes with the configured parallelism. In summary, the hostid change will affect the order of repair nodes initially, but not parallelism so the number of nodes at a time going through repair before and after won't change. I guess there is no good solution to it. I am fine with adding this to "NEWS.txt". Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
