Demi M. Obenour:
Checking application/pgp-signature: FAILURE
-- Start of PGP signed section.
> On 10/6/20 9:47 AM, Wietse Venema wrote:
> > Demi M. Obenour:
> >> Patch (made against 3.5.7) attached. I lightly tested it locally and
> >> it seems to work, but there could very well be bugs. I am virtually
> >> certain that I violated the Postfix coding style somewhere, sorry.
> >> I can also send the patch inline if you prefer.
> >
> > I can read it. I'll try to massage the code later this week (instead
> > of a dozen back-and-forth email messages about awkward details).
>
> Thank you so much! Should I look for it in a future unstable release?
>
> > mail_addr_find -> maps_find
> > "+" -> var_rcpt_delim
>
> Good catch! I knew I missed something there.
>
> > allow 'not found' users, similar to smtpd_sender_login_maps
>
> Would it be possible to make this configurable? The documentation
> seems to imply that reject_sender_login_mismatch considers ?not
> found? to be an error, while reject_known_sender_login_mismatch
> does not. On systems I administer, I would prefer for an unknown
> user to not be allowed to submit mail, but I understand if this cannot
> be the default. The patch I submitted blocks ?not found? users,
> but the default local_sender_login_maps (static:*) matches every user,
> so the default behavior is the same as now.
For me, 'not found' also includes the case that the user is not found
in the passwd file.
> > put the new code inside its own function, avoiding gotos
>
> Indeed that would be an improvement.
Generally, one function per concept.
Wietse
