On Mon, Apr 20, 2020 at 11:53:35AM -0700, PGNet Dev wrote:
> On 4/20/20 11:14 AM, Wietse Venema wrote:
> > Postfix versions 3.5.1, 3.4.11, 3.3.9, 3.2.14:
> >
> > * Bitrot workaround for broken builds after an incompatible change
> > in GCC 10.
>
> confirming, 3.5.1 build/install/exec all well-behaved again with _both_
> gcc-10 & clang-10
>
> Apr 20 11:51:36 test postfix/master[43824]: daemon started -- version
> 3.5.1, configuration /usr/local/etc/postfix
Yes, many thanks for the continued support.
Speaking of new compilers, don't know how much you care to work around
silly warnings, but C-compilers are getting increasingly nitpicky (I
suspect Haskell-envy). Though the build works just fine on MacOS
Catalina, the compiler issues warnings for pointer arithmetic on string
literals:
milter.c:623:7: warning: adding 'int' to a string does not append to the
string [-Wstring-plus-int]
milter.c:623:7: note: use array indexing to silence this warning
milter.c:624:7: warning: adding 'int' to a string does not append to the
string [-Wstring-plus-int]
milter.c:624:7: note: use array indexing to silence this warning
milter.c:625:7: warning: adding 'int' to a string does not append to the
string [-Wstring-plus-int]
milter.c:625:7: note: use array indexing to silence this warning
milter.c:629:7: warning: adding 'int' to a string does not append to the
string [-Wstring-plus-int]
milter.c:629:7: note: use array indexing to silence this warning
milter.c:630:7: warning: adding 'int' to a string does not append to the
string [-Wstring-plus-int]
milter.c:630:7: note: use array indexing to silence this warning
smtpd_check.c:489:8: warning: adding 'int' to a string does not append to
the string [-Wstring-plus-int]
smtpd_check.c:489:8: note: use array indexing to silence this warning
smtpd_check.c:490:8: warning: adding 'int' to a string does not append to
the string [-Wstring-plus-int]
smtpd_check.c:490:8: note: use array indexing to silence this warning
smtpd_check.c:491:8: warning: adding 'int' to a string does not append to
the string [-Wstring-plus-int]
smtpd_check.c:491:8: note: use array indexing to silence this warning
smtpd_check.c:492:8: warning: adding 'int' to a string does not append to
the string [-Wstring-plus-int]
smtpd_check.c:492:8: note: use array indexing to silence this warning
smtpd_check.c:496:8: warning: adding 'int' to a string does not append to
the string [-Wstring-plus-int]
smtpd_check.c:496:8: note: use array indexing to silence this warning
smtpd_check.c:497:8: warning: adding 'int' to a string does not append to
the string [-Wstring-plus-int]
smtpd_check.c:497:8: note: use array indexing to silence this warning
smtpd_check.c:501:8: warning: adding 'int' to a string does not append to
the string [-Wstring-plus-int]
smtpd_check.c:501:8: note: use array indexing to silence this warning
smtpd_check.c:502:8: warning: adding 'int' to a string does not append to
the string [-Wstring-plus-int]
smtpd_check.c:502:8: note: use array indexing to silence this warning
I personally haven't met any programmers who expect ("string" + 7) to
mean ("string7") in C. But perhaps that's now a thing... Appeasing the
compiler's latest fetish seems to require:
--- a/src/milter/milter.c
+++ b/src/milter/milter.c
@@ -620,14 +620,14 @@ void milter_disc_event(MILTERS *milters)
* names by skipping the redundant "milter_" prefix.
*/
static ATTR_OVER_TIME time_table[] = {
- 7 + VAR_MILT_CONN_TIME, DEF_MILT_CONN_TIME, 0, 1, 0,
- 7 + VAR_MILT_CMD_TIME, DEF_MILT_CMD_TIME, 0, 1, 0,
- 7 + VAR_MILT_MSG_TIME, DEF_MILT_MSG_TIME, 0, 1, 0,
+ &VAR_MILT_CONN_TIME[7], DEF_MILT_CONN_TIME, 0, 1, 0,
+ &VAR_MILT_CMD_TIME[7], DEF_MILT_CMD_TIME, 0, 1, 0,
+ &VAR_MILT_MSG_TIME[7], DEF_MILT_MSG_TIME, 0, 1, 0,
0,
};
static ATTR_OVER_STR str_table[] = {
- 7 + VAR_MILT_PROTOCOL, 0, 1, 0,
- 7 + VAR_MILT_DEF_ACTION, 0, 1, 0,
+ &VAR_MILT_PROTOCOL[7], 0, 1, 0,
+ &VAR_MILT_DEF_ACTION[7], 0, 1, 0,
0,
};
--
Viktor.
