Hi,
On Sun, May 05, 2019 at 01:30:56PM +0200, Jeremie Courreges-Anglas wrote:
> > Adding major bumps for poppler-qt5 and poppler-cpp because of
> > incompatible changes in some "private" parts, even if the corresponding
> > headers aren't included in the packages.
> >
> > I'm still waiting for my bulk update on amd64 to finish, but in case
> > anyone want's to do some testing in advance...
>
> Builds fine on amd64 with ports-gcc and ld.bfd (can't test on sparc64
> right now). Hopefully that test should be enough for ports-gcc archs.
Thanks for that test.
> Looks like symbols from poppler-qt5 didn't change yet there's a major
> bump. I'm not saying this is a problem though (eg we have situations in
> base where we bump both libA and libB when libB depends on libA).
>
> /usr/local/lib/libpoppler-qt5.so.7.1 -->
> /usr/ports/pobj/poppler-0.76.0/fake-amd64/usr/local/lib/libpoppler-qt5.so.8.0
> No dynamic export changes
I usually just look at a diff of the old and new version of poppler
to check wether upstream may have missed a (minor or major) bump.
Honestly I even forgot the name of the tool for comparing shared
library export ;-)
In this case it was this chunk in qt5/src/poppler-private.h
@@ -123,7 +125,7 @@ namespace Poppler {
DocumentData(const DocumentData &) = delete;
DocumentData& operator=(const DocumentData &) = delete;
- void addTocChildren( QDomDocument * docSyn, QDomNode * parent, const
GooList * items );
+ void addTocChildren( QDomDocument * docSyn, QDomNode * parent, const
std::vector<::OutlineItem*> * items );
void setPaperColor(const QColor &color)
{
That is the declaration of a public method in class DocumentData
in the namespace Poppler. If i see such a change, I add a major
bump (if upstream didn't already do).
Since you didn't find any change in this case, I could drop the
bump if you insist (but it would be a little mess on my build machine
and in my package repository).
Ciao,
Kili
