On Sun, Aug 04 2019, Matthias Kilian <[email protected]> wrote:
> Hi,
>
> update to poppler-0.79.0.
>
> Tested on amd64 with apvlv, evince and gummi.

Build-tested on sparc64 with the same consumer ports.

> check_sym reported some symbol removals for poppler-glib, thus the
> major bump.

That's weird, when I look at the output of check_sym here:

--8<--
/usr/local/lib/libpoppler.so.52.0 --> 
/usr/ports/pobj/poppler-0.79.0/fake-amd64/usr/local/lib/libpoppler.so.53.0
Dynamic export changes:
added:
        _Z9greallocnPviibb
        
_ZN10FormWidget19setAdditionalActionEN5Annot25FormAdditionalActionsTypeERK9GooString
        _ZN11AnnotWidget16setNewAppearanceEO6Object
        
_ZN11AnnotWidget23setFormAdditionalActionEN5Annot25FormAdditionalActionsTypeERK9GooString
        _ZN11PSOutputDev11writeHeaderEiPK12PDFRectangleS2_iPKc
        
_ZN11PSOutputDev13writeDocSetupEP7CatalogRKNSt3__16vectorIiNS2_9allocatorIiEEEEb
        _ZN14LinkJavaScript12createObjectEP4XRefRK9GooString
        _ZN22AnnotAppearanceBuilder18lineEndingXShortenE20AnnotLineEndingStyled
        
_ZN22AnnotAppearanceBuilder21lineEndingXExtendBBoxE20AnnotLineEndingStyled

removed:
        _Z9greallocnPviib
        
_ZN11PSOutputDev11writeHeaderERKNSt3__16vectorIiNS0_9allocatorIiEEEEPK12PDFRectangleS9_iPc
        
_ZN11PSOutputDev13writeDocSetupEP6PDFDocP7CatalogRKNSt3__16vectorIiNS4_9allocatorIiEEEEb
        
_ZN22AnnotAppearanceBuilder27shortenLineSegmentForEndingE20AnnotLineEndingStyledd

PLT added:
        _Z9greallocnPviibb
        _ZN10SplashClip4growEi
        
_ZN11AnnotWidget23setFormAdditionalActionEN5Annot25FormAdditionalActionsTypeERK9GooString
        _ZN11PSOutputDev11writeHeaderEiPK12PDFRectangleS2_iPKc
        
_ZN11PSOutputDev13writeDocSetupEP7CatalogRKNSt3__16vectorIiNS2_9allocatorIiEEEEb
        _ZN14LinkJavaScript12createObjectEP4XRefRK9GooString

PLT removed:
        _Z9greallocnPviib
        
_ZN11PSOutputDev11writeHeaderERKNSt3__16vectorIiNS0_9allocatorIiEEEEPK12PDFRectangleS9_iPc
        
_ZN11PSOutputDev13writeDocSetupEP6PDFDocP7CatalogRKNSt3__16vectorIiNS4_9allocatorIiEEEEb

/usr/local/lib/libpoppler-glib.so.19.1 --> 
/usr/ports/pobj/poppler-0.79.0/fake-amd64/usr/local/lib/libpoppler-glib.so.20.0
Dynamic export changes:
added:
        poppler_document_create_dests_tree

External reference changes:
added:
        _ZN7Catalog12getDestsDestEi
        _ZN7Catalog12getDestsNameEi
        _ZN7Catalog15getDestNameTreeEv
        _ZN7Catalog19getDestNameTreeDestEi
        _ZN7Catalog8numDestsEv
        _ZN8NameTree7getNameEi
        g_prefix_error
        g_strcmp0
        g_tree_insert
        g_tree_new_full
        g_type_add_instance_private

removed:
        g_type_class_add_private
        g_type_instance_get_private

PLT added:
        poppler_dest_free

/usr/local/lib/libpoppler-qt5.so.7.1 --> 
/usr/ports/pobj/poppler-0.79.0/fake-amd64/usr/local/lib/libpoppler-qt5.so.7.2
Dynamic export changes:
added:
        _ZN7Poppler13FormFieldIconC1EPNS_17FormFieldIconDataE
        _ZN7Poppler13FormFieldIconC1ERKS0_
        _ZN7Poppler13FormFieldIconC2EPNS_17FormFieldIconDataE
        _ZN7Poppler13FormFieldIconC2ERKS0_
        _ZN7Poppler13FormFieldIconD1Ev
        _ZN7Poppler13FormFieldIconD2Ev
        _ZN7Poppler13FormFieldIconaSERKS0_
        _ZN7Poppler15FormFieldButton7setIconERKNS_13FormFieldIconE
        _ZN7Poppler17FormFieldIconData7getDataERKNS_13FormFieldIconE
        _ZN7Poppler9FormField12setPrintableEb
        _ZNK7Poppler15FormFieldButton4iconEv
        _ZNK7Poppler9FormField11isPrintableEv

External reference changes:
added:
        _ZN11AnnotWidget16setNewAppearanceEO6Object
        _ZSt7nothrow
        _ZnwmRKSt9nothrow_t

PLT added:
        _ZN7Poppler17FormFieldIconData7getDataERKNS_13FormFieldIconE

/usr/local/lib/libpoppler-cpp.so.11.0 --> 
/usr/ports/pobj/poppler-0.79.0/fake-amd64/usr/local/lib/libpoppler-cpp.so.11.0
No dynamic export changes
-->8--

the "Dynamic export changes" calls for:
- a major bump for libpoppler
- a minor bump for libpoppler-glib
- a minor bump for libpoppler-qt5

But you propose a major bump for both libpoppler and libpoppler-glib.
Not a big deal, but I figured I'd ask...

> If anyone wants to test on other archs or with other applications,
> please let me know. Otherwise I'd like to commit this on tuesday.

LGTM

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to