On 2019/02/16 17:14, Alessandro DE LAURENZIS wrote:
> Hello Edd,
>
> On 15/02/2019 21:31, Edd Barrett wrote:
> > Hi Alessandro,
> >
> > On Mon, Feb 04, 2019 at 08:33:08PM +0100, Alessandro DE LAURENZIS wrote:
> > > thanks for your time to revisit this port; please find enclosed the
> > > unified
> > > diff.
> >
> > Seems like there's a problem with the diff:
> >
> > ---8<---
> > $ patch -CEsp0 < /tmp/ipe.diff
> > ...
> > Patching file patches/patch-src_common_mak using Plan A...
> > Hunk #1 failed at 1.
> > ...
> > --->8---
>
> Weird... I can apply it here without issues.
I didn't try the old one, but this one does apply ok.
> >
> > Then here's a few more comments, from just reading the diff:
> >
> > > -V = 7.1.2
> > > +VERSION = 7.2
> > > +V = ${VERSION}.9
> >
> > Having a V and a VERSION is a little confusing.
> >
> > How about MAJOR_V and V, for the major version and the full version?
> >
>
> Sure. Done.
You can just set V=7.2.9 and use
MASTER_SITES= https://dl.bintray.com/otfried/generic/ipe/${V:R}/
> > > +MODLUA_VERSION = 5.3
> >
> > Is this a hard requirement? It'd be better to use the default ports
> > version (which is currently 5.1, but I think you can just remove this
> > line if 5.1 is OK).
>
> That's definitely an hard requirement; package doesn't compile with LUA
> versions older that 5.3
Please set MODLUA_SA=Yes.
> > > + DL_LIBS=""
> >
> > ^ What's this for?
>
> In 2 files (${WRKSRC}/src/common.mak and ${WRKSRC}/src/snapcraft.mak) there
> is the following assignment:
>
> DL_LIBS ?= -ldl
>
> so either we patch them or define an empty DL_LIBS in the port's Makefile, I
> think. Or maybe there are better ways to manage that?
It's fine like you have it.
> >
> > > +-LUA_PACKAGE ?= lua5.3
> > > ++LUA_PACKAGE ?= lua53
> >
> > I think we should try to substitute that lua version in, so that it
> > doesn't break if we change the lua version.
> >
>
> Done using ${LUA_DEP_VERSION} and ${SUBST_CMD} in pre-build target.
You have some bogus ${LUA_DEP_VERSION} in the PLIST. If you fix them up
you should be able to stop it readding them with
UPDATE_PLIST_ARGS += -i LUA_DEP_VERSION
