Hi Alessandro,
On Mon, Feb 04, 2019 at 08:33:08PM +0100, Alessandro DE LAURENZIS wrote:
> thanks for your time to revisit this port; please find enclosed the unified
> diff.
Seems like there's a problem with the diff:
---8<---
$ patch -CEsp0 < /tmp/ipe.diff
...
Patching file patches/patch-src_common_mak using Plan A...
Hunk #1 failed at 1.
...
--->8---
Then here's a few more comments, from just reading the diff:
> -V = 7.1.2
> +VERSION = 7.2
> +V = ${VERSION}.9
Having a V and a VERSION is a little confusing.
How about MAJOR_V and V, for the major version and the full version?
> +MODLUA_VERSION = 5.3
Is this a hard requirement? It'd be better to use the default ports
version (which is currently 5.1, but I think you can just remove this
line if 5.1 is OK).
> + DL_LIBS=""
^ What's this for?
> +-LUA_PACKAGE ?= lua5.3
> ++LUA_PACKAGE ?= lua53
I think we should try to substitute that lua version in, so that it
doesn't break if we change the lua version.
> + -- On Linux, you could use: prefs.keyboard = "onboard &"
> +- prefs.keyboard = nil
> ++ prefs.keyboard = "xvkbd &"
Are these defaults, or are we hard-coding an application here?
By the way, I'm happy for you to take MAINTAINER if you'd like to.
Cheers
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
