On 06/29/18 04:57, Klemens Nanni wrote:
On Fri, Jun 29, 2018 at 02:01:07AM -0400, Brian Callahan wrote:Plays perfectly well on my laptop. Built fine on armv7 and arm64, but no audio hardware to test on those machines.Builds fine on sparc64 as well, didn't have something to run-test, though.
I've been testing with vgm files from arcade PCBs I own, for example: http://vgmrips.net/packs/pack/kingdom-grandprix-toaplan-2
The Github page links to a vgmrips.net, not .com.
Fixed thanks.
For the first four hunks of patch_Makefile I'd probably just pass those variables instead of patching them.
Not quite. CFLAGS and LDFLAGS needed more wrangling than a simple MAKE_FLAGS. And at that point I'd rather just keep everything (or most everything) to the patch. But I'm not sure how much it matters as long as it's documented in the patch. I noticed I can remove USE_LIBAO=1 from MAKE_ENV too since that's set as default.
The other patches are trivial: Mind trying to upstream those? The project seems young, maybe another release (with stable assets *hint*) will be around the corner soon ;-)
Yes I was planning to upstream the formatting fixes. Can't make any guarantees about a new release though!
Anyhow, a new port tarball looks like the attached. ~Brian
vgmplay.tgz
Description: Binary data
