Looking for someone to check and commit the change to the CVS.
Elias.
2018-05-04 21:00 GMT-03:00 Elias M. Mariani <[email protected]>:
> Updated to 3.2.8 from 3.2.6.
> New spyder.tar.gz attached and also in openbsd-wip:
> https://github.com/jasperla/openbsd-wip/tree/master/devel/spyder
>
> Again, thanks Stuart for the help.
> Elias.
>
> 2018-05-04 17:13 GMT-03:00 Elias M. Mariani <[email protected]>:
>> Thanks for the help Stuart,
>>
>>> - stray whitespace in Makefile (<space><tab> and <tab><end-of-line>)
>> Fixed.
>>
>>> - don't include a maintainer line if it's the default (i.e. ports@)
>> Fixed.
>>
>>> - would prefer to see the FLAVOR bits next to MODULES for python
>>> things so it's obvious
>> Done.
>>
>>> - RUN_DEPENDS etc should be one entry per line
>> Done.
>>
>>> - why do you @comment the appdata.xml file?
>> My mistake, replaced by ${MODPY_COMMENT}, is only for the python3 flavor.
>>> - it doesn't use our standard handling for multi-version python ports
>>> with py- and py3- prefixes. I think in this case that's alright as it's
>>> more of an application than library and upstream has their own py3
>>> renaming so it seems better to keep that, however this is a bit ugly:
>>>
>>> MAJOR_VERSION=
>>> .if ${FLAVOR:Mpython3}
>>> MAJOR_VERSION= 3
>>> PKGNAME = spyder${MODPY_MAJOR_VERSION}-${MODPY_EGG_VERSION}
>>> .endif
>>>
>>> I'd replace it with:
>>>
>>> .if ${FLAVOR:Mpython3}
>>> MAJOR_VERSION= 3
>>> PKGNAME= spyder3-${MODPY_EGG_VERSION}
>>> .else
>>> MAJOR_VERSION=
>>> .endif
>> Changed in the Makefile, yes, it was ugly...
>> The naming convention seems to be attaching a 3 at the end of the
>> application name in this cases, even the setup.py itself makes spyder
>> or spyder3 executable for the python and python3 version.
>>
>> I'm working on openbsd-wip, but I will send here a new tar.gz version
>> when finished.
