On 2018/04/26 00:39, Elias M. Mariani wrote:
> [NEW] devel/spyder: (depends on the update of py-rope)
I haven't tried running, but from reading:
- stray whitespace in Makefile (<space><tab> and <tab><end-of-line>)
- don't include a maintainer line if it's the default (i.e. ports@)
- would prefer to see the FLAVOR bits next to MODULES for python
things so it's obvious
- RUN_DEPENDS etc should be one entry per line
- why do you @comment the appdata.xml file?
- it doesn't use our standard handling for multi-version python ports
with py- and py3- prefixes. I think in this case that's alright as it's
more of an application than library and upstream has their own py3
renaming so it seems better to keep that, however this is a bit ugly:
MAJOR_VERSION=
.if ${FLAVOR:Mpython3}
MAJOR_VERSION= 3
PKGNAME = spyder${MODPY_MAJOR_VERSION}-${MODPY_EGG_VERSION}
.endif
I'd replace it with:
.if ${FLAVOR:Mpython3}
MAJOR_VERSION= 3
PKGNAME= spyder3-${MODPY_EGG_VERSION}
.else
MAJOR_VERSION=
.endif
