On Tue, Apr 24 2018, Frederic Cambus <[email protected]> wrote:
> On Tue, Apr 24, 2018 at 10:35:20AM +0200, Jeremie Courreges-Anglas wrote:
>
>> > I'm aware that we are not supposed to import ports using GH_TAGNAME, I
>> > opened an issue asking for a proper release tarball but I haven't got
>> > any feedback from upstream yet. I can host the tarball on distfiles.pl
>> > if that's preferred?
>>
>> I'd prefer this, yes, but no strong opinion.
>
> I will leave as it for now so portroach can find updates.
>
>> > From DESCR:
>> >
>> > wrk is a modern HTTP benchmarking tool capable of generating significant
>> > load when run on a single multi-core CPU. It combines a multithreaded
>> > design
>> > with scalable event notification systems such as epoll and kqueue.
>> >
>> > Comments? OK?
>>
>> Would you mind installing a bit more documentation? Like, SCRIPTING
>> (and README.md?) in share/doc and scripts/* in share/examples?
>
> Makes sense yes, here is a new tarball implementing your suggestions.
>
> Comments? OK?
Please use ${INSTALL_DATA} instead of cp in do-install (unless you have
a good reason?). Except for this, ok jca@
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
