Hi Klemens --

Please reply to everyone not just the list.

On 12/10/17 19:58, Klemens Nanni wrote:
On Sun, Dec 10, 2017 at 07:01:11PM -0500, Brian Callahan wrote:
Attached is an updated port, combining both of your ports.
I made both of you MAINTAINER, you can share.
Looks good to me, thanks for fixing -Os.

As for this port conflicting with vis(1), I don't really mind.

/home/brian $ which vis
/usr/bin/vis

even after installing the port, which I think is correct. Set this port to
an alias in your shell. I assume that's how a lot of people are going to run
it anyway, something like:
alias vi='/usr/local/bin/vis'
Most probably, but renaming was done to prevent conflicts regardless of
aliases and PATH. If this too much however, I won't object.

This is not some famous piece of software like the GNU coreutils, where accidentally using the base utility vs. the GNU utility could really matter.

However, the line and column display on the bottom right corner is very
broken here. You two should fix that and resubmit.
What does "very broken" mean? Both column and row index have always been
correct for me. Please describe your problem in detail.


They bleed into each other.
When I load vis by itself, I get:
0% 1, 1
When I press i to enter insert mode, it becomes:
0% 1, 1  1
Then if I type, say, "OpenBSD" it shows:
100% 1, 1 71
Let's say I finish the sentence and now I wrote "OpenBSD is an operating system." it will display:
100% 1, 10311
Now let's say I press Enter to move to the next line, it says:
97% 2, 0311

I would say this is very broken. This is within tmux, which limited testing suggests makes a difference, but there are still bleeding issues when not in tmux. Specifically, outside of tmux, pressing i in a blank file still produces
0% 1, 1  1

~Brian

Reply via email to