Hi Carolyn and Klemens -- On 12/10/17 09:56, Klemens Nanni wrote:
On Thu, Dec 07, 2017 at 11:45:16PM -0800, Carolyn Saunders wrote:I just made a rudimentary port of vis, "[a] vi-like editor based on Plan 9's structural regular expressions," which can be found at https://github.com/martanne/vis. However, it exposes the binary "vis" which conflicts with another program in OpenBSD's base. How should this be rectified? This is my first port so I'm still unfamiliar with the way this is usually handled.I've been sitting on my unfinished vis port for way too long, thanks for bringing it up again.Some comments inline and my port attached as it's finally ready for submission. The version number in your port directory name should be stripped.V = 0.4 GH_ACCOUNT = martanne GH_PROJECT = vis GH_TAGNAME = v${V} DISTNAME = vis-${V}GH_* is all you need here; zap V, DISTNAME is set automatically.MAKE_FLAGS = BINDIR="${TRUPREFIX}/bin" \ CONFIGURE_STYLE= simple CONFIGURE_ARGS= --mandir="${TRUEPREFIX}/man"Why not just --prefix=${PREFIX} --mandif=${PREFIX}/man?NO_TEST= Yesvis has a test suite and it should be used. Running it through our ports framework even revealed a libtermkey bug when TERM is unset. My port works fine on amd64, I've been using it as my main editor exclusively for over a year now. All tests pass. Feedback?
Attached is an updated port, combining both of your ports. I made both of you MAINTAINER, you can share. As for this port conflicting with vis(1), I don't really mind. /home/brian $ which vis /usr/bin/viseven after installing the port, which I think is correct. Set this port to an alias in your shell. I assume that's how a lot of people are going to run it anyway, something like:
alias vi='/usr/local/bin/vis'However, the line and column display on the bottom right corner is very broken here. You two should fix that and resubmit.
~Brian
vis.tgz
Description: Binary data
