On Tue, Jun 13, 2017 at 10:32:06AM +0200, Landry Breuil wrote:
> On Tue, Jun 13, 2017 at 10:10:01AM +0200, Antoine Jacoutot wrote:
> > On Tue, Jun 13, 2017 at 09:51:13AM +0200, Landry Breuil wrote:
> > > On Tue, Jun 13, 2017 at 09:46:55AM +0200, Antoine Jacoutot wrote:
> > > > On Tue, Jun 13, 2017 at 09:42:02AM +0200, Landry Breuil wrote:
> > > > > On Tue, Jun 13, 2017 at 09:24:14AM +0200, Antoine Jacoutot wrote:
> > > > > > On Mon, Jun 12, 2017 at 10:05:48PM +0200, Landry Breuil wrote:
> > > > > > > On Mon, Jun 12, 2017 at 11:33:07AM +0200, Landry Breuil wrote:
> > > > > > > > On Mon, Jun 12, 2017 at 10:03:05AM +0100, Stuart Henderson
> > > > > > > > wrote:
> > > > > > > > > On 2017/06/12 11:00, Antoine Jacoutot wrote:
> > > > > > > > > > Is it expected to have an unversionned lib?
> > > > > > > > > > lib/libpdalcpp.so
> > > > > > > > >
> > > > > > > > > Ah I missed that one. So probably add pdalcpp and drop
> > > > > > > > > pdal_plugin_*
> > > > > > > > > from SHARED_LIBS?
> > > > > > > >
> > > > > > > > From what i understood, libpdalcpp.so is a linker script...
> > > > > > >
> > > > > > > New version, with .orig files removed, patches added to move
> > > > > > > plugins to
> > > > > > > their own location in share/pdal/plugins as upstream tried to do
> > > > > > > but
> > > > > > > failed, no versionning of plugins, and fixing the python deps.
> > > > > > > didnt
> > > > > >
> > > > > > -DNUMPY_INCLUDE_DIR=${LOCALBASE}/lib/python${MODPY_DEFAULT_VERSION_3}/site-packages/numpy/core/include/
> > > > > > You can probably use this intead:
> > > > > > -DNUMPY_INCLUDE_DIR=${MODPY_SITEPKG}/numpy/core/include/
> > > > >
> > > > > Right
> > > > >
> > > > > > BUILD_DEPENDS = math/py-numpy,python3
> > > > > > I think this should be:
> > > > > > BUILD_DEPENDS = math/py-numpy${MODPY_FLAVOR}
> > > > >
> > > > > Wasnt sure, as i didnt explicitely set a python flavor.. but you're
> > > > > right.
> > > > >
> > > > > > > change anything about libpdalcpp.so as it's used by pdal-config
> > > > > > > --libs... in case something builds against pdal i'll
> > > > > > > check/revisit that
> > > > > > > part.
> > > > > >
> > > > > > Not sure what you mean by "used by pdal-config" but loading a
> > > > > > versionned .so
> > > > > > file should just work as well. Anyway, no opinion here :-)
> > > > >
> > > > > pdal-config --libs says -L/usr/local/lib -lpdalcpp, so somethign
> > > > > linking
> > > > > against pdal this way will read libpdalcpp.so and link against the
> > > > > libs
> > > > > in it ? i suppose so.
> > > >
> > > > That's correct. One more reason to version that lib :-)
> > >
> > > it's not a lib, but a linker script :)
> >
> > Oh. How weird to name it like this :-)
> > I guess it's fine as is then.
> >
> > > $cat /usr/local/lib/libpdalcpp.so
> > > INPUT (-lpdal_base -lpdal_util)
>
> And here's what i have now in mystuff/, all feedback/comments should
> have been adressed...
OK aja
--
Antoine
