On 2017/06/12 10:47, Landry Breuil wrote:
> Hi,
> 
> here's a quick port for https://www.pdal.io, a point data translation
> library (think like GDAL, but for point cloud data/3d stuff). The next
> step would be porting https://github.com/pgpointcloud/pointcloud to
> store data into postgresql instead of LAS files..
> 
> oks welcome, i'll try to pushback our patches upstream..
> 
> Landry

MODPY_VERSION = 3.6

should probably be ${MODPY_DEFAULT_VERSION_3} rather than
hardcoded?

        
-DNUMPY_INCLUDE_DIR=${LOCALBASE}/lib/python2.7/site-packages/numpy/core/include/
 \

hmm, 3.6 above and 2.7 here?

SHARED_LIBS +=  pdal_plugin_filter_predicate 0.0 # 5.1
SHARED_LIBS +=  pdal_plugin_filter_programmable 0.0 # 5.1
SHARED_LIBS +=  pdal_plugin_reader_pgpointcloud 0.0 # 5.1
SHARED_LIBS +=  pdal_plugin_writer_pgpointcloud 0.0 # 5.1

if these are just dlopen()d plugins I think they probably don't want the
.0.0. other comments on that welcome though! (as it's cmake.port.mk, listing
them in SHARED_LIBS will trigger them having the version added).

Also a couple of .orig's in the patches/ dir.

Reply via email to