On 2017/04/25 14:42, Paul Irofti wrote:
> A few comments below.
>
> > Index: Makefile
> > ===================================================================
> [...]
> > -MODULES = lang/python
> > -BUILD_DEPENDS = devel/doxygen
> > +MODULES = lang/python \
> > + gcc4
> > +
> > +MODGCC4_LANGS = c++
> > +MODGCC4_ARCHS = ${GCC3_ARCHS} ${GCC4_ARCHS}
>
> Is this a new idiom? gcc3 archs under gcc4 archs?
MODGCC4_ARCHS : tells ports infra to use ports GCC for the following arches
GCC3_ARCHS : contains a list of arches where the base compiler is gcc3
GCC4_ARCHS : contains a list of arches where the base compiler is gcc4.2.1
This is meant to be a more targeted alternative to "MODGCC4_ARCHS = *"
which avoids using ports gcc on arches that use clang as the base compiler.
However it's incomplete because the gcc4 module also adds to WANTLIB.
At this point I think I'd prefer to just use * until we've worked
through the details with the new USE_CXX bits and how to handle WANTLIB.
> > +++ pkg/DESCR 23 Apr 2017 18:34:30 -0000
> > @@ -1,8 +1,7 @@
> > -The name GiNaC is an iterated and recursive abbreviation for GiNaC is
> > -Not a CAS, where CAS stands for Computer Algebra System. It has been
> > -developed to become a replacement engine for xloops which in the past
> > -was powered by the Maple CAS. Its design is revolutionary in a sense
> > -that contrary to other CAS it does not try to provide extensive
> > -algebraic capabilities and a simple programming language but instead
> > -accepts a given language (C++) and extends it by a set of algebraic
> > -capabilities.
> > +The name GiNaC is an iterated and recursive abbreviation for GiNaC is Not a
> > +CAS, where CAS stands for Computer Algebra System. It has been developed to
> > +become a replacement engine for xloops which in the past was powered by the
> > +Maple CAS. Its design is revolutionary in a sense that contrary to other
> > CAS it
> > +does not try to provide extensive algebraic capabilities and a simple
> > +programming language but instead accepts a given language (C++) and
> > extends it
> > +by a set of algebraic capabilities.
>
> Did you wrap the text here? Why do you need this?
I don't like that change, the text flows more smoothly in the original..
