A few comments below.

> Index: Makefile
> ===================================================================
[...]
> -MODULES =       lang/python
> -BUILD_DEPENDS =      devel/doxygen
> +MODULES =    lang/python \
> +             gcc4
> +
> +MODGCC4_LANGS =      c++
> +MODGCC4_ARCHS =      ${GCC3_ARCHS} ${GCC4_ARCHS}

Is this a new idiom? gcc3 archs under gcc4 archs?

> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/math/ginac/distinfo,v
> retrieving revision 1.9
> diff -u -p -u -p -r1.9 distinfo
> --- distinfo  27 Jun 2015 10:26:38 -0000      1.9
> +++ distinfo  23 Apr 2017 18:34:30 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (ginac-1.6.4.tar.bz2) = YkEVgha09oxiXOfYQ9W2sHAwT4fn/I9AdbdlAcoPPGA=
> -SIZE (ginac-1.6.4.tar.bz2) = 1028044
> +SHA256 (ginac-1.7.2.tar.bz2) = JLdbYcXLJyU041s/LP1k8FOyiu50Aq9LDlaexN4h2Lc=
> +SIZE (ginac-1.7.2.tar.bz2) = 1056339
> Index: patches/patch-check_check_matrices_cpp
> ===================================================================
> RCS file: patches/patch-check_check_matrices_cpp
> diff -N patches/patch-check_check_matrices_cpp
> --- patches/patch-check_check_matrices_cpp    17 Mar 2009 11:53:01 -0000      
> 1.2
> +++ /dev/null 1 Jan 1970 00:00:00 -0000
> @@ -1,12 +0,0 @@
> -$OpenBSD: patch-check_check_matrices_cpp,v 1.2 2009/03/17 11:53:01 pirofti 
> Exp $
> ---- check/check_matrices.cpp.orig    Tue Feb 17 14:39:22 2009
> -+++ check/check_matrices.cpp Tue Mar 10 16:12:26 2009
> -@@ -217,7 +217,7 @@ unsigned check_matrices()
> -     result += rational_matrix_determinants();  cout << '.' << flush;
> -     result += funny_matrix_determinants();  cout << '.' << flush;
> -     result += compare_matrix_determinants();  cout << '.' << flush;
> --    result += symbolic_MATrix_inverse();  cout << '.' << flush;
> -+    //result += symbolic_matrix_inverse();  cout << '.' << flush;
> -     
> -     return result;
> - }


This patch is broken, see the MAT capitalization. Does this regress test
pass now w/o disabling the inverse test?

> Index: pkg/DESCR
> ===================================================================
> RCS file: /cvs/ports/math/ginac/pkg/DESCR,v
> retrieving revision 1.1.1.1
> diff -u -p -u -p -r1.1.1.1 DESCR
> --- pkg/DESCR 1 Dec 2007 13:38:38 -0000       1.1.1.1
> +++ pkg/DESCR 23 Apr 2017 18:34:30 -0000
> @@ -1,8 +1,7 @@
> -The name GiNaC is an iterated and recursive abbreviation for GiNaC is
> -Not a CAS, where CAS stands for Computer Algebra System. It has been
> -developed to become a replacement engine for xloops which in the past
> -was powered by the Maple CAS. Its design is revolutionary in a sense
> -that contrary to other CAS it does not try to provide extensive
> -algebraic capabilities and a simple programming language but instead
> -accepts a given language (C++) and extends it by a set of algebraic
> -capabilities.
> +The name GiNaC is an iterated and recursive abbreviation for GiNaC is Not a
> +CAS, where CAS stands for Computer Algebra System. It has been developed to
> +become a replacement engine for xloops which in the past was powered by the
> +Maple CAS. Its design is revolutionary in a sense that contrary to other CAS 
> it
> +does not try to provide extensive algebraic capabilities and a simple
> +programming language but instead accepts a given language (C++) and extends 
> it
> +by a set of algebraic capabilities.

Did you wrap the text here? Why do you need this?

Reply via email to