On Fri, Mar 31, 2017 at 12:33:03AM +0200, Jeremie Courreges-Anglas wrote:

> Marcus Glocker <[email protected]> writes:
> 
> > On Thu, Mar 30, 2017 at 09:45:34PM +0200, Jeremie Courreges-Anglas wrote:
> >
> >> Marcus Glocker <[email protected]> writes:
> >> 
> >> > KiwiIRC is a web-based IRC client built using Node.js.  It runs as
> >> > standalone which means it doesn't require an underlying HTTP server.
> >> >
> >> > Comments, OKs?
> >> 
> >> You can't use npm install like this, the build process should not fetch
> >> from the network.
> >
> > Hmm, ok.  Any good idea how to solve this?  Unfortunately it's required
> > to fetch some modules so you can do the build afterwards.
> 
> No precise idea, I don't know mich about node/npm.
> 
> Creating ports for all deps seems to be what fedora does:
> 
>   https://fedoraproject.org/wiki/Packaging:Node.js
> 
> An alternative would be to make npm use a local cache populated with
> distfiles explicitely registered in Makefile/distinfo.  But I don't know
> whether this would actually work.

Hmm, ok, I will check the URL and have a think.

> [...]
> 
> >> -$(command -v nodejs || command -v node) 
> >> $basedir/server/helpers/launcher.js "$@"
> >> +$(command -v nodejs || command -v node) 
> >> $basedir/server/helpers/launcher.js "$@" -p /var/log/kiwiirc/kiwiirc.pid
> >> 
> >> /var/log seems like a weird choice for a pid file, you can install
> >> /var/run/kiwiirc in the rc script.  Is this pid file actually needed?
> >
> > No, the pid file doesn't seem to be required.  There seems no easy
> > way to disable it.  Therefore I just send it to /dev/null instead.
> 
> Ah, I see.  Doesn't this result in (failed) attempts to unlink
> /dev/null?  Maybe it would be cleaner to bite the bullet and install
> /var/run/kiwiirc.  The README still lists the pidfile btw.

I didn't noticed an error during stop/restart but I agree it's cleaner
to just create the pid file in /var/run/kiwiirc.  README fixed, also for
the installation path location.

So there is the node/npm thing left now I guess ...

Attachment: kiwiirc.tgz
Description: application/tar-gz

Reply via email to