On Thu, Mar 30, 2017 at 09:45:34PM +0200, Jeremie Courreges-Anglas wrote: > Marcus Glocker <[email protected]> writes: > > > KiwiIRC is a web-based IRC client built using Node.js. It runs as > > standalone which means it doesn't require an underlying HTTP server. > > > > Comments, OKs? > > You can't use npm install like this, the build process should not fetch > from the network.
Hmm, ok. Any good idea how to solve this? Unfortunately it's required to fetch some modules so you can do the build afterwards. > I think you should use a do-build target instead of > do-configure/NO_BUILD. Ok, I have changed it. > Installing to /usr/local/kiwiirc seems dubious at best, shouldn't stuff > be installed in /usr/local/lib/kiwiirc and/or /usr/local/share/kiwiirc? I did orientate myself at www/kibana which also installs in /usr/local/kibana. But I agree that /usr/local/lib/kiwiirc would be a better place. I moved it there now. > -$(command -v nodejs || command -v node) $basedir/server/helpers/launcher.js > "$@" > +$(command -v nodejs || command -v node) $basedir/server/helpers/launcher.js > "$@" -p /var/log/kiwiirc/kiwiirc.pid > > /var/log seems like a weird choice for a pid file, you can install > /var/run/kiwiirc in the rc script. Is this pid file actually needed? No, the pid file doesn't seem to be required. There seems no easy way to disable it. Therefore I just send it to /dev/null instead. > pexp="node: kiwiirc*" <- did you mean pexp="node: kiwiirc.*" (a regular > expression)? Yes, sorry, fixed. > Standard reminder: the tree is locked right now. Yeah, I've noticed this as well in the meantime ...
kiwiirc.tgz
Description: application/tar-gz
