Dmitrij D. Czarkoff said:
> Stuart Henderson said:
> > On 2016/04/21 19:35, Christian Weisgerber wrote:
> >> Dmitrij D. Czarkoff:
> >>
> >>>> I think you should just set
> >>>> INSTALL_STRIP =
> >>>> in the ports (or modules) that require it and be done with it.
> >>>> No point in introducing yet another variable.
> >>>
> >>> INSTALL_STRIP is mentioned in mk.conf(5), so it is a user setting.
> >>> /etc/mk.conf may contain INSTALL_STRIP=-s, and that would override
> >>> INSTALL_STRIP= from port.
> >>
> >> In practice, INSTALL_STRIP has two possible values: "-s" and "".
> >> "-s" is already the default, so the only user setting that makes
> >> any sense is "". Having some ports already set it to "" is just
> >> fine.
> >>
> >> A few ports already do this.
> >
> > Makes sense to me. go-bootstrap needs it too.
>
> Well, then asking for OKs for the following patch.
While at it, maybe we should move description of INSTALL_STRIP from
mk.conf(5) to bsd.port.mk(5), as apparently it is now used this way?
--
Dmitrij D. Czarkoff
Index: bsd.port.mk.5
===================================================================
RCS file: /cvs/src/share/man/man5/bsd.port.mk.5,v
retrieving revision 1.434
diff -u -p -r1.434 bsd.port.mk.5
--- bsd.port.mk.5 22 Mar 2016 16:02:02 -0000 1.434
+++ bsd.port.mk.5 21 Apr 2016 21:16:27 -0000
@@ -1743,6 +1743,14 @@ User settings.
If set to
.Sq Yes ,
do not print anything when ignoring a port.
+.It Ev INSTALL_STRIP
+Flag for
+.Ev INSTALL_PROGRAM
+macro for stripping binaries.
+Default is
+.Sq -s .
+Set to empty value to disable stripping.
+.Sq
.It Ev INSTALL_{PROGRAM,SCRIPT,DATA,MAN}[_DIR]
Macros to use to install a program, a script, data, or a man page (or the
corresponding directory), respectively.
Index: mk.conf.5
===================================================================
RCS file: /cvs/src/share/man/man5/mk.conf.5,v
retrieving revision 1.31
diff -u -p -r1.31 mk.conf.5
--- mk.conf.5 31 Mar 2016 15:53:25 -0000 1.31
+++ mk.conf.5 21 Apr 2016 21:13:55 -0000
@@ -64,7 +64,7 @@ The following variables are set by
.In bsd.own.mk ,
if they are not already defined.
Defaults are in brackets.
-.Bl -tag -width INSTALL_STRIP
+.Bl -tag -width INSTALL_COPY
.It Ev BINGRP
Binary group.
.Bq bin
@@ -110,16 +110,6 @@ This is to be used when building an inst
system can either be installed with copies, or copy-if-different using a
single knob.
.Bq Fl c
-.It Ev INSTALL_STRIP
-The flag passed to the install program to cause the binary to be stripped.
-This is to be used when building an install script so that the entire
-system can be made stripped/not-stripped using a single knob.
-Note that
-.Ev INSTALL_STRIP
-is not set if
-.Ev ${DEBUG}
-is defined.
-.Bq Fl s
.It Ev LIBDIR
Base path for library installation.
.Bq Pa /usr/lib
