On Thu, 21 Apr 2016 15:12:24 +0200
"Dmitrij D. Czarkoff" <[email protected]> wrote:
> Dmitrij D. Czarkoff said:
> > Edd Barrett said:
> > > On Thu, Apr 21, 2016 at 01:38:54AM +0200, Adam Wolk wrote:
> > > > +# Use INSTALL_SCRIPT to prevent stripping go binaries
> > >
> > > Is it worth adding a INSTALL_GO_PROGRAM in the lang/go MODULE to
> > > avoid confusion?
> >
> > I'd rather go with more generic change. Patch below adds
> > INSTALL_NO_STRIP macro to bsd.port.mk. Setting this macro to "Yes"
> > makes INSTALL_STRIP empty. go.port.mk sets INSTALL_NO_STRIP to
> > "Yes".
> >
> > Diff against bsd.port.mk.5 in src also included.
>
> Forgot to define INSTALL_NO_STRIP.
>
OK awolk@ on condition that INSTALL_NO_STRIP = Yes is added to
lang/go/Makefile. The go port itself doesn't use it's module but
installs go binaries and has the same warnings. Looks ok with your diff
plus the additional INSTALL_NO_STRIP.
Reverting logstash/forwarder change from yesterday will also be
required. I can do that if you commit the go port changes.
Patch to revert logstash:
Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/logstash/forwarder/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- Makefile 21 Apr 2016 00:07:08 -0000 1.8
+++ Makefile 21 Apr 2016 14:11:54 -0000
@@ -5,7 +5,7 @@ COMMENT= collect logs locally in prepara
GH_ACCOUNT= elastic
GH_PROJECT= logstash-forwarder
GH_TAGNAME= v0.4.0
-REVISION= 2
+REVISION= 3
MODULES= lang/go
@@ -16,9 +16,8 @@ WANTLIB += c pthread
pre-configure:
${SUBST_CMD} ${WRKSRC}/logstash-forwarder.conf.example
-# Use INSTALL_SCRIPT to prevent stripping go binaries
do-install:
- ${INSTALL_SCRIPT} ${MODGO_WORKSPACE}/bin/logstash-forwarder \
+ ${INSTALL_PROGRAM} ${MODGO_WORKSPACE}/bin/logstash-forwarder \
${PREFIX}/sbin/
${INSTALL_DATA_DIR} ${PREFIX}/share/{doc,examples}/logstash-forwarder/
${INSTALL_DATA} ${WRKSRC}/README.md \
