On 2014/09/24 03:38, Dmitrij D. Czarkoff wrote: > > - a couple of instances of "V=foo, DISTNAME=xyz-$V" where $V isn't used > > elsewhere - just set the version directly in DISTNAME > > Makefile.inc appends "-DVERSION=$V" to CFLAGS, so all of these "V=foo" > are called at least twice.
ok > > LIB_DEPENDS = telephony/baresip/re databases/mysql,-main > > - split onto multiple lines as done in other ports > > - s/mysql/mariadb > > Fixed. I would prefer listing mariadb (which is only required for one > of optional modules) as optional dependency in MESSAGE, but this > approach seems to be unpopular these days. As it's a library dependency rather than a run dependency, it needs to be recorded. The alternative is to split this module off to a subpackage. > I could statically link everything into baresip – patching a couple of > makefiles would be enough. I am not sure it is really needed though. This could be done if users of !shared arch want to run it there, though, as you mentioned, dependencies are likely to be a problem. I'll try to review the updated files soon.
