Stuart Henderson said: > Problems common to a few of these ports: > > - restund and baresip have a number of .so modules which look like they're > required for operation, they should probably have SHARED_ONLY=Yes and merge > PFRAG.shared into PLISTs
Added SHARED_ONLY=Yes to restund. It is possible to link all modules statically into baresip, and port makes use of this possibility, so I left baresip intact. (I am installing OpenBSD on vax VM to test baresip port on static-only architecture, although I am unsure whether all dependencies of baresip are available there at all.) > - a couple of instances of "V=foo, DISTNAME=xyz-$V" where $V isn't used > elsewhere - just set the version directly in DISTNAME Makefile.inc appends "-DVERSION=$V" to CFLAGS, so all of these "V=foo" are called at least twice. > - missing blank line after rcs id comment Fixed. > Others: > > restund.rc > - commented-out daemon_timeout line. should it be set? if not, remove it. Fixed. > LIB_DEPENDS = telephony/baresip/re databases/mysql,-main > - split onto multiple lines as done in other ports > - s/mysql/mariadb Fixed. I would prefer listing mariadb (which is only required for one of optional modules) as optional dependency in MESSAGE, but this approach seems to be unpopular these days. > what look like dlopen()'d modules I could statically link everything into baresip – patching a couple of makefiles would be enough. I am not sure it is really needed though. -- Dmitrij D. Czarkoff
baresip.tgz
Description: application/tar-gz
