On 27 August 2014 21:29, Jérémie Courrèges-Anglas <[email protected]> wrote:
>
> Untested so far, one nit below.
>
> Index: pkg/PLIST
> ===================================================================
> RCS file: /var/cvs/ports/sysutils/duplicity/pkg/PLIST,v
> retrieving revision 1.13
> diff -u -p -r1.13 PLIST
> --- pkg/PLIST 3 Apr 2014 07:59:35 -0000 1.13
> +++ pkg/PLIST 21 Aug 2014 10:27:13 -0000
> @@ -1,8 +1,14 @@
> @comment $OpenBSD: PLIST,v 1.13 2014/04/03 07:59:35 ajacoutot Exp $
> bin/duplicity
> bin/rdiffdir
> +@comment
> lib/python${MODPY_VERSION}/site-packages/duplicity/backends/dpbxbackend.py
> +@comment
> lib/python${MODPY_VERSION}/site-packages/duplicity/backends/dpbxbackend.pyc
>
> Doesn't look right, since...
>
> -@comment
> lib/python${MODPY_VERSION}/site-packages/duplicity/backends/dpbxbackend.py
> -@comment
> lib/python${MODPY_VERSION}/site-packages/duplicity/backends/dpbxbackend.pyc
> +lib/python${MODPY_VERSION}/site-packages/duplicity/backends/dpbxbackend.py
>
> +lib/python${MODPY_VERSION}/site-packages/duplicity/backends/dpbxbackend.pyc
>
> ... the files are added here anyway. The CHANGELOG says that it was
> fixed in this release, so it probably makes sense to ship those files
> now. Anyone with a dropbox account?
>
>
Correct, it isn't right. It is either included or not included :-)
I have just created a dropbox account specifically for testing, it isn't a
feature that I use duplicity for. All my testing was done on amd64, macppc
with par2 (with and without), AWS S3, file and sftp.
Dropbox testing has failed. The py-dropbox API is needed it looks like,
something else for me to look at if this feature is to be used. At this
point, I think, leave the @comment intact for the dpbxbackend and I'll
revisit its inclusion when I have sorted the dependencies.
Thoughts?
