On Mon, Mar 04, 2013 at 01:18:56PM -0500, Stuart Cassoff wrote: > > The port builds and runs fine. Still I would suggest the following changes: > > As I mentioned in my last message, I get crashes when trying to login to a > server. > Mind you, I don't know jabber well, so any tips are welcome.
Could you please describe the problem in more details? Any error messages? Any output to terminal? > > ============================================================================== > > --- a/net/tkabber/base/pkg/README Mon Mar 04 18:24:27 2013 +0100 > > +++ b/net/tkabber/base/pkg/README Mon Mar 04 19:24:50 2013 +0100 > > @@ -11,4 +11,3 @@ > > * textproc/ispell (spell checking) > > * x11/tkcon (Tk console) > > * x11/tktray (iconify Tkabber) > > -* x11/xosd (OSD support) > > Why not just have these as RUN_DEPENDS? > Give the user the maximum experience. I'm not sure whether forcing optional dependencies is a good idea: any of these may happen to be an optional dependency elsewhere, so it may break things. I believe I had some problems of the kind with xosd before, and ISpell may also get caught up somewhere. IMO it's generally wise to keep optional things up to users. > Thanks for spotting this. > It would be greatly appreciated if existing packages > (like KHIM, part of tklib) could be used instead of the bundled ones. > I also notice a TclXML in there, maybe that can be excised as well? I'll look into it later. > KHIM doesn't need 8.4. > Nothing needs 8.4. > [package require Tcl 8.4] tends to mean *minumum* 8.4. I'm not particularly sure why I thought KHIM needed 8.4. Probably I had a reason to think so. -- Dmitrij D. Czarkoff
