On Wed, Jan 30, 2013 at 04:05:28PM +0300, Kirill Bychkov wrote:
> Hi.
> This is a port of tkabber-0.11.1, Tk Jabber client. It was sent to
> ports by Anton Yabchinskiy in Nov 200 and by Dmitrij Czarkoff four
> years later in Nov 2012.
> I'm using it on i386 and amd64 since it was first submitted to
> ports@ by Anton.
> This is reworked port, partly based on a work of previous submitters.
>
> Comments? OKs?
The port builds and runs fine. Still I would suggest the following changes:
==============================================================================
--- a/net/tkabber/base/pkg/README Mon Mar 04 18:24:27 2013 +0100
+++ b/net/tkabber/base/pkg/README Mon Mar 04 19:24:50 2013 +0100
@@ -11,4 +11,3 @@
* textproc/ispell (spell checking)
* x11/tkcon (Tk console)
* x11/tktray (iconify Tkabber)
-* x11/xosd (OSD support)
==============================================================================
--- a/net/tkabber/plugins/pkg/PLIST Mon Mar 04 18:24:27 2013 +0100
+++ b/net/tkabber/plugins/pkg/PLIST Mon Mar 04 19:24:50 2013 +0100
@@ -667,18 +667,18 @@
share/tkabber-plugins/tkabber-khim/ChangeLog
share/tkabber-plugins/tkabber-khim/INSTALL
share/tkabber-plugins/tkabber-khim/VERSION
-share/tkabber-plugins/tkabber-khim/khim/
-share/tkabber-plugins/tkabber-khim/khim/ROOT.msg
-share/tkabber-plugins/tkabber-khim/khim/cs.msg
-share/tkabber-plugins/tkabber-khim/khim/da.msg
-share/tkabber-plugins/tkabber-khim/khim/de.msg
-share/tkabber-plugins/tkabber-khim/khim/en.msg
-share/tkabber-plugins/tkabber-khim/khim/es.msg
-share/tkabber-plugins/tkabber-khim/khim/khim.tcl
-share/tkabber-plugins/tkabber-khim/khim/pkgIndex.tcl
-share/tkabber-plugins/tkabber-khim/khim/pl.msg
-share/tkabber-plugins/tkabber-khim/khim/ru.msg
-share/tkabber-plugins/tkabber-khim/khim/uk.msg
+@comment share/tkabber-plugins/tkabber-khim/khim/
+@comment share/tkabber-plugins/tkabber-khim/khim/ROOT.msg
+@comment share/tkabber-plugins/tkabber-khim/khim/cs.msg
+@comment share/tkabber-plugins/tkabber-khim/khim/da.msg
+@comment share/tkabber-plugins/tkabber-khim/khim/de.msg
+@comment share/tkabber-plugins/tkabber-khim/khim/en.msg
+@comment share/tkabber-plugins/tkabber-khim/khim/es.msg
+@comment share/tkabber-plugins/tkabber-khim/khim/khim.tcl
+@comment share/tkabber-plugins/tkabber-khim/khim/pkgIndex.tcl
+@comment share/tkabber-plugins/tkabber-khim/khim/pl.msg
+@comment share/tkabber-plugins/tkabber-khim/khim/ru.msg
+@comment share/tkabber-plugins/tkabber-khim/khim/uk.msg
share/tkabber-plugins/tkabber-khim/msgs/
share/tkabber-plugins/tkabber-khim/msgs/es.msg
share/tkabber-plugins/tkabber-khim/msgs/pl.msg
==============================================================================
--- a/net/tkabber/plugins/pkg/README Mon Mar 04 18:24:27 2013 +0100
+++ b/net/tkabber/plugins/pkg/README Mon Mar 04 19:24:50 2013 +0100
@@ -9,3 +9,7 @@
ln -s ${PREFIX}/share/tkabber-plugins/aniemoticons/ \
~/.tkabber/plugins/
+
+Dependencies for Tkabber plugins:
+* x11/xosd ("osd" plugin)
+* devel/tklib ("tkabber-khim" plugin)
==============================================================================
About PLIST change: "tkabber-khim" plugin uses bundled KHIM package, which
requires Tk 8.4. As I get it, KHIM is now a part of tklib, so I think it would
be better to comment the bundled KHIM out and suggest "devel/tklib" dependency
in README then to tie the package to Tk 8.4.
--
Dmitrij D. Czarkoff
