On Mon, Sep 14, 2009 at 02:12:18PM +0100, Stuart Henderson wrote:
> On 2009/09/11 21:04, James Turner wrote:
> > Attached is a port of the Fossil SCM [1]. Tested on i386.
> > 
> > [1] http://fossil-scm.org
> 
> Mostly good, but can you check out CFLAGS please, it's building
> everything with -g -Os (CFLAGS in the environment should definitely
> override the optimiser flags and we don't usually want to build -g
> unless the builder has specified that). The -Wall can stay there.
> Sometimes there's some simple way to override e.g. with configure
> args, or you may have to patch the Makefile along these lines:
> 
> CFLAGS?=-g -Os
> CFLAGS+=-Wall
> 
> There are also some various "warning: cast from pointer to integer of
> different size" if you build on 64-bit arch, the ones I looked at in
> makeheaders.c don't seem to be a problem, I haven't looked over the
> ones in the bundled sqlite but they don't happen in our normal sqlite
> port so it's probably worth looking at why... (or maybe switching
> to sqlite from ports rather than the bundled copy, I don't know).

Attached is an updated port of fossil. I removed the hardcoded compiler
optimizations. I believe I fixed the 64bit compiler warnings and have
tested on amd64 and i386. I also added gnupg as a run depend since
fossil can use it to sign manifests.

Attachment: fossil.tar.gz
Description: application/tar-gz

Reply via email to