On 2009/09/11 21:04, James Turner wrote:
> Attached is a port of the Fossil SCM [1]. Tested on i386.
>
> [1] http://fossil-scm.org
Mostly good, but can you check out CFLAGS please, it's building
everything with -g -Os (CFLAGS in the environment should definitely
override the optimiser flags and we don't usually want to build -g
unless the builder has specified that). The -Wall can stay there.
Sometimes there's some simple way to override e.g. with configure
args, or you may have to patch the Makefile along these lines:
CFLAGS?=-g -Os
CFLAGS+=-Wall
There are also some various "warning: cast from pointer to integer of
different size" if you build on 64-bit arch, the ones I looked at in
makeheaders.c don't seem to be a problem, I haven't looked over the
ones in the bundled sqlite but they don't happen in our normal sqlite
port so it's probably worth looking at why... (or maybe switching
to sqlite from ports rather than the bundled copy, I don't know).
+++ Mon Sep 14 13:43:43 BST 2009
===> Checking files for fossil-20090911230450
`/usr/ports/distfiles/fossil-src-20090911230450.tar.gz' is up to date.
>> (SHA256) fossil-src-20090911230450.tar.gz: OK
===> Extracting for fossil-20090911230450
===> Patching for fossil-20090911230450
===> Configuring for fossil-20090911230450
===> Building for fossil-20090911230450
gcc -g -O2 -o translate ./src/translate.c
./translate ./src/add.c >add_.c
./translate ./src/allrepo.c >allrepo_.c
./translate ./src/bag.c >bag_.c
./translate ./src/blob.c >blob_.c
./translate ./src/branch.c >branch_.c
./translate ./src/browse.c >browse_.c
./translate ./src/captcha.c >captcha_.c
./translate ./src/cgi.c >cgi_.c
./translate ./src/checkin.c >checkin_.c
./translate ./src/checkout.c >checkout_.c
./translate ./src/clearsign.c >clearsign_.c
./translate ./src/clone.c >clone_.c
./translate ./src/comformat.c >comformat_.c
./translate ./src/configure.c >configure_.c
./translate ./src/construct.c >construct_.c
./translate ./src/content.c >content_.c
./translate ./src/db.c >db_.c
./translate ./src/delta.c >delta_.c
./translate ./src/deltacmd.c >deltacmd_.c
./translate ./src/descendants.c >descendants_.c
./translate ./src/diff.c >diff_.c
./translate ./src/diffcmd.c >diffcmd_.c
./translate ./src/doc.c >doc_.c
./translate ./src/encode.c >encode_.c
./translate ./src/file.c >file_.c
./translate ./src/http.c >http_.c
./translate ./src/http_socket.c >http_socket_.c
./translate ./src/http_transport.c >http_transport_.c
./translate ./src/info.c >info_.c
./translate ./src/login.c >login_.c
./translate ./src/main.c >main_.c
./translate ./src/manifest.c >manifest_.c
./translate ./src/md5.c >md5_.c
./translate ./src/merge.c >merge_.c
./translate ./src/merge3.c >merge3_.c
./translate ./src/name.c >name_.c
./translate ./src/pivot.c >pivot_.c
./translate ./src/pqueue.c >pqueue_.c
./translate ./src/printf.c >printf_.c
./translate ./src/rebuild.c >rebuild_.c
./translate ./src/report.c >report_.c
./translate ./src/rss.c >rss_.c
./translate ./src/rstats.c >rstats_.c
./translate ./src/schema.c >schema_.c
./translate ./src/setup.c >setup_.c
./translate ./src/sha1.c >sha1_.c
./translate ./src/shun.c >shun_.c
./translate ./src/stat.c >stat_.c
./translate ./src/style.c >style_.c
./translate ./src/sync.c >sync_.c
./translate ./src/tag.c >tag_.c
./translate ./src/th_main.c >th_main_.c
./translate ./src/timeline.c >timeline_.c
./translate ./src/tkt.c >tkt_.c
./translate ./src/tktsetup.c >tktsetup_.c
./translate ./src/undo.c >undo_.c
./translate ./src/update.c >update_.c
./translate ./src/url.c >url_.c
./translate ./src/user.c >user_.c
./translate ./src/verify.c >verify_.c
./translate ./src/vfile.c >vfile_.c
./translate ./src/wiki.c >wiki_.c
./translate ./src/wikiformat.c >wikiformat_.c
./translate ./src/winhttp.c >winhttp_.c
./translate ./src/xfer.c >xfer_.c
./translate ./src/zip.c >zip_.c
gcc -g -O2 -o mkindex ./src/mkindex.c
/tmp//ccA3j6hK.o(.text+0x540): In function `scan_for_func':
src/mkindex.c:146: warning: strcpy() is almost always misused, please use
strlcpy()
./mkindex add_.c allrepo_.c bag_.c blob_.c branch_.c browse_.c captcha_.c
cgi_.c checkin_.c checkout_.c clearsign_.c clone_.c comformat_.c
configure_.c construct_.c content_.c db_.c delta_.c deltacmd_.c
descendants_.c diff_.c diffcmd_.c doc_.c encode_.c file_.c http_.c
http_socket_.c http_transport_.c info_.c login_.c main_.c manifest_.c
md5_.c merge_.c merge3_.c name_.c pivot_.c pqueue_.c printf_.c
rebuild_.c report_.c rss_.c rstats_.c schema_.c setup_.c sha1_.c shun_.c
stat_.c style_.c sync_.c tag_.c th_main_.c timeline_.c tkt_.c
tktsetup_.c undo_.c update_.c url_.c user_.c verify_.c vfile_.c wiki_.c
wikiformat_.c winhttp_.c xfer_.c zip_.c >page_index.h
gcc -g -O2 -o makeheaders ./src/makeheaders.c
src/makeheaders.c: In function `ParsePreprocessor':
src/makeheaders.c:2140: warning: cast from pointer to integer of different size
src/makeheaders.c:2140: warning: cast from pointer to integer of different size
src/makeheaders.c:2159: warning: cast from pointer to integer of different size
src/makeheaders.c:2159: warning: cast from pointer to integer of different size
src/makeheaders.c:2170: warning: cast from pointer to integer of different size
src/makeheaders.c:2170: warning: cast from pointer to integer of different size
src/makeheaders.c: In function `DocumentationDump':
src/makeheaders.c:2955: warning: cast from pointer to integer of different size
/tmp//ccS2Ui5N.o(.text+0x3f08): In function `AddParameters':
src/makeheaders.c:3150: warning: strcpy() is almost always misused, please use
strlcpy()
/tmp//ccS2Ui5N.o(.text+0x49c): In function `CreateDecl':
src/makeheaders.c:562: warning: sprintf() is often misused, please use
snprintf()
awk '{ printf "#define MANIFEST_UUID \"%s\"\n", $1}' ./src/../manifest.uuid
>VERSION.h
awk '{ printf "#define MANIFEST_VERSION \"[%.10s]\"\n", $1}'
./src/../manifest.uuid >>VERSION.h
awk '$1=="D"{printf "#define MANIFEST_DATE \"%s %s\"\n",
substr($2,1,10),substr($2,12)}' ./src/../manifest >>VERSION.h
./makeheaders add_.c:add.h allrepo_.c:allrepo.h bag_.c:bag.h blob_.c:blob.h
branch_.c:branch.h browse_.c:browse.h captcha_.c:captcha.h cgi_.c:cgi.h
checkin_.c:checkin.h checkout_.c:checkout.h clearsign_.c:clearsign.h
clone_.c:clone.h comformat_.c:comformat.h configure_.c:configure.h
construct_.c:construct.h content_.c:content.h db_.c:db.h delta_.c:delta.h
deltacmd_.c:deltacmd.h descendants_.c:descendants.h diff_.c:diff.h
diffcmd_.c:diffcmd.h doc_.c:doc.h encode_.c:encode.h file_.c:file.h
http_.c:http.h http_socket_.c:http_socket.h http_transport_.c:http_transport.h
info_.c:info.h login_.c:login.h main_.c:main.h manifest_.c:manifest.h
md5_.c:md5.h merge_.c:merge.h merge3_.c:merge3.h name_.c:name.h
pivot_.c:pivot.h pqueue_.c:pqueue.h printf_.c:printf.h rebuild_.c:rebuild.h
report_.c:report.h rss_.c:rss.h rstats_.c:rstats.h schema_.c:schema.h
setup_.c:setup.h sha1_.c:sha1.h shun_.c:shun.h stat_.c:stat.h style_.c:style.h
sync_.c:sync.h tag_.c:tag.h th_main_.c:th_main.h timeline_.c:timeline.h
tkt_.c:tkt.h tktsetup_.c:tktsetup.h undo_.c:undo.h update_.c:update.h
url_.c:url.h user_.c:user.h verify_.c:verify.h vfile_.c:vfile.h wiki_.c:wiki.h
wikiformat_.c:wikiformat.h winhttp_.c:winhttp.h xfer_.c:xfer.h zip_.c:zip.h
./src/sqlite3.h ./src/th.h VERSION.h
touch headers
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o add.o -c add_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o allrepo.o -c allrepo_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o bag.o -c bag_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o blob.o -c blob_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o branch.o -c branch_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o browse.o -c browse_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o captcha.o -c captcha_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o cgi.o -c cgi_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o checkin.o -c checkin_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o checkout.o -c checkout_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o clearsign.o -c clearsign_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o clone.o -c clone_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o comformat.o -c comformat_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o configure.o -c configure_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o construct.o -c construct_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o content.o -c content_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o db.o -c db_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o delta.o -c delta_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o deltacmd.o -c deltacmd_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o descendants.o -c descendants_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o diff.o -c diff_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o diffcmd.o -c diffcmd_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o doc.o -c doc_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o encode.o -c encode_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o file.o -c file_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o http.o -c http_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o http_socket.o -c http_socket_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o http_transport.o -c http_transport_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o info.o -c info_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o login.o -c login_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o main.o -c main_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o manifest.o -c manifest_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o md5.o -c md5_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o merge.o -c merge_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o merge3.o -c merge3_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o name.o -c name_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o pivot.o -c pivot_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o pqueue.o -c pqueue_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o printf.o -c printf_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o rebuild.o -c rebuild_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o report.o -c report_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o rss.o -c rss_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o rstats.o -c rstats_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o schema.o -c schema_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o setup.o -c setup_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o sha1.o -c sha1_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o shun.o -c shun_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o stat.o -c stat_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o style.o -c style_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o sync.o -c sync_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o tag.o -c tag_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o th_main.o -c th_main_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o timeline.o -c timeline_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o tkt.o -c tkt_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o tktsetup.o -c tktsetup_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o undo.o -c undo_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o update.o -c update_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o url.o -c url_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o user.o -c user_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o verify.o -c verify_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o vfile.o -c vfile_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o wiki.o -c wiki_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o wikiformat.o -c wikiformat_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o winhttp.o -c winhttp_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o xfer.o -c xfer_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -o zip.o -c zip_.c
gcc -g -Os -Wall -O2 -pipe -I. -I./src -DSQLITE_OMIT_LOAD_EXTENSION=1
-DSQLITE_THREADSAFE=0 -DSQLITE_DEFAULT_FILE_FORMAT=4
-Dlocaltime=fossil_localtime -c ./src/sqlite3.c -o sqlite3.o
src/sqlite3.c: In function `sqlite3ValueText':
src/sqlite3.c:46945: warning: cast from pointer to integer of different size
src/sqlite3.c: In function `sqlite3VdbeChangeP4':
src/sqlite3.c:47802: warning: cast from pointer to integer of different size
src/sqlite3.c: In function `sqlite3VdbeRecordUnpack':
src/sqlite3.c:49748: warning: cast from pointer to integer of different size
src/sqlite3.c: In function `sqlite3_blob_open':
src/sqlite3.c:57739: warning: cast to pointer from integer of different size
src/sqlite3.c: In function `sqlite3RefillIndex':
src/sqlite3.c:67668: warning: cast to pointer from integer of different size
src/sqlite3.c: In function `trimFunc':
src/sqlite3.c:71087: warning: cast from pointer to integer of different size
src/sqlite3.c: In function `sqlite3OpenTable':
src/sqlite3.c:71615: warning: cast to pointer from integer of different size
src/sqlite3.c: In function `sqlite3GenerateConstraintChecks':
src/sqlite3.c:72907: warning: cast to pointer from integer of different size
src/sqlite3.c: In function `sqlite3_get_table':
src/sqlite3.c:81217: warning: cast to pointer from integer of different size
src/sqlite3.c: In function `sqlite3_free_table':
src/sqlite3.c:81261: warning: cast from pointer to integer of different size
src/sqlite3.c: In function `codeOneLoopStart':
src/sqlite3.c:87228: warning: cast to pointer from integer of different size
src/sqlite3.c:87262: warning: cast to pointer from integer of different size
src/sqlite3.c:87393: warning: cast to pointer from integer of different size
src/sqlite3.c: In function `sqlite3WhereBegin':
src/sqlite3.c:87924: warning: cast to pointer from integer of different size
gcc -g -Os -Wall -O2 -pipe -I. -I./src -I./src -c ./src/th.c -o th.o
gcc -g -Os -Wall -O2 -pipe -I. -I./src -I./src -c ./src/th_lang.c -o th_lang.o
src/th_lang.c: In function `simple_command':
src/th_lang.c:576: warning: cast from pointer to integer of different size
gcc -g -Os -Wall -o fossil add.o allrepo.o bag.o blob.o branch.o browse.o
captcha.o cgi.o checkin.o checkout.o clearsign.o clone.o comformat.o
configure.o construct.o content.o db.o delta.o deltacmd.o descendants.o
diff.o diffcmd.o doc.o encode.o file.o http.o http_socket.o
http_transport.o info.o login.o main.o manifest.o md5.o merge.o merge3.o
name.o pivot.o pqueue.o printf.o rebuild.o report.o rss.o rstats.o
schema.o setup.o sha1.o shun.o stat.o style.o sync.o tag.o th_main.o
timeline.o tkt.o tktsetup.o undo.o update.o url.o user.o verify.o
vfile.o wiki.o wikiformat.o winhttp.o xfer.o zip.o sqlite3.o th.o
th_lang.o -lz
blob.o(.text+0xf63): In function `blob_write_to_file':
/usr/obj/ports/fossil-20090911230450/fossil-src-20090911230450/blob_.c:665:
warning: strcpy() is almost always misused, please use strlcpy()
captcha.o(.text+0x136): In function `test_captcha':
/usr/obj/ports/fossil-20090911230450/fossil-src-20090911230450/captcha_.c:401:
warning: sprintf() is often misused, please use snprintf()
--- Mon Sep 14 13:44:06 BST 2009
