On Sun, Aug 15, 2021 at 06:13:39PM +0200, Rafael Sadowski wrote: > Looks like scrot has found a new home, so please find below a simple > update diff. Used on amd64 for a while.
Works for me; I'm unsure if we really want to drop the strlcpy/strlcat patches. The code is rather scary with or without them, so they're probably more pain than what they're worth... > Index: patches/patch-src_options_c > =================================================================== > RCS file: patches/patch-src_options_c > diff -N patches/patch-src_options_c > --- patches/patch-src_options_c 8 Jul 2011 11:25:47 -0000 1.2 > +++ /dev/null 1 Jan 1970 00:00:00 -0000 > @@ -1,26 +0,0 @@ > -$OpenBSD: patch-src_options_c,v 1.2 2011/07/08 11:25:47 jasper Exp $ > ---- src/options.c.orig Mon Jun 23 14:09:08 2003 > -+++ src/options.c Fri Jul 8 13:22:30 2011 > -@@ -141,6 +141,7 @@ name_thumbnail(char *name) > - > - length = strlen(name) + 7; > - new_title = gib_emalloc(length); > -+ memset(new_title, 0, sizeof(new_title)); This hunk didn't apply since gib_emalloc() was replaced with malloc(). I'm unsure what the patch actually fixed. Should this be changed to use calloc()? either way, ok
