rsadowski, I think the X11BASE patch is worth considering.
> I see that upstream now provides release tarballs which is much better.
> So it's good to ditch the autoconf stuff and use MASTER_SITES.
Probably some confusion in terminology, but what does autoconf have to
do with release tarballs?
> +GH_ACCOUNT = resurrecting-open-source-projects
> +GH_PROJECT = scrot
> +GH_TAGNAME = 1.6
>From Makefile.template:
# /releases/ -> preferred. ignore GH_*, just use MASTER_SITES and DISTNAME.
> ++ if(opt.exec) {
> ++ if (pledge("cpath exec prot_exec rpath stdio wpath proc", NULL) == -1) {
This update should remain decoupled from adding pledge, IMO.
I'm generally skeptical of ports pledges that add prot_exec (except for
the monsters where it's unavoidable). Can this be reduced to something
sane by hoisting whatever needs it? Also, please sort the promises to
canonical order (roughly the order in the manual, look at what is done
in base).
> -@@ -148,11 +149,11 @@ name_thumbnail(char *name)
> + new_title = malloc(length);
> ++ memset(new_title, 2, length);
This doesn't look right at all.