On Feb 21, 2025, at 19:34, Hiroki Tagato <tagat...@freebsd.org> wrote:
> On 2025/02/22 11:29, Hiroki Tagato wrote: >> On 2025/02/20 1:26, Mark Millard wrote: >>> On Feb 19, 2025, at 06:42, Hiroki Tagato <tagat...@freebsd.org> wrote: >>> >>>> On 2025/02/19 18:05, Jason E. Hale wrote: >>>>> On Wed, Feb 19, 2025 at 3:20 AM Hiroki Tagato <tagat...@freebsd.org> >>>>> wrote: >>>>>> >>>>>> On 2025/02/18 19:03, Mark Millard wrote: >>>>>>> >>>>>>> >>>>>>> On Feb 17, 2025, at 22:27, Mark Millard <mark...@yahoo.com> wrote: >>>>>>> >>>>>>>> On Feb 17, 2025, at 19:38, Mark Millard <mark...@yahoo.com> wrote: >>>>>> . . . >>>>>> >>>>> Hi all, >>>>> I maintain archivers/libunrar and after seeing this, I just committed >>>>> a patch [1] to my port to fix this problem. The libunrar patches have >>>>> some additional guff to add openssl support that should not be >>>>> included for chromium-based projects, but the concept is basically the >>>>> same. Should be pretty easy to adapt. >>>>> [1] https://cgit.freebsd.org/ports/commit/? >>>>> id=96e53c0c65faa691e18c0a5558d8f445e6010a70 >>>> >>>> Hi Jason, >>>> >>>> Thanks a lot for letting me know the commit. I will shortly prepare a >>>> patch for electron ports based on that. >>> . . . >> Hi Mark, Hello. >> There was a report from mikael@ that electron32 built fine on aarch64 >> hardware. So I suspect you have some custom settings in make.conf and/or >> poudriere.conf. >> Do you have custom settings? My context fits with the reference to 96e53c0c6: QUOTE archivers/libunrar: Support crc and crypto flags on aarch64 If CPU flags crc or crytpo are set, e.g. -march=armv8-a+crc+crypto, build would fail with missing headers because this was only implemented for glibc and Apple. END QUOTE I generally have -mcpu=cortex-a76 involved for my aarch64 builds for the primary machines. That would mean that crc and crypto would be impicitly enabled. > Anyway, I have prepared a patch for electron 32 and 33 based on the commit: > https://cgit.freebsd.org/ports/commit/?id=96e53c0c65faa691e18c0a5558d8f445e6010a70 I've applied the patch file and started an electron32 build with no completing build activity or other significant activity, including not having started building electron33. That should get to a preliminary result as soon as possible. Then, if it looks worthwhile, I could try to build electron33 as well. The prerequisites had already been built during the prior bulk -a experiment. So only electron is building. > Can you try again with the attached patch if/when you have available > resources? > # I don't have an aarch64 hardware so I can't test it by myself. I'll let you know what happens with electron32. === Mark Millard marklmi at yahoo.com
