On Feb 19, 2025, at 06:42, Hiroki Tagato <tagat...@freebsd.org> wrote:
> On 2025/02/19 18:05, Jason E. Hale wrote:
>> On Wed, Feb 19, 2025 at 3:20 AM Hiroki Tagato <tagat...@freebsd.org> wrote:
>>>
>>> On 2025/02/18 19:03, Mark Millard wrote:
>>>>
>>>>
>>>> On Feb 17, 2025, at 22:27, Mark Millard <mark...@yahoo.com> wrote:
>>>>
>>>>> On Feb 17, 2025, at 19:38, Mark Millard <mark...@yahoo.com> wrote:
>>>>>
>>>>>> I was doing a poudriere(-devel) "bulk -ca" test on an aarch64
>>>>>> system and ran into electron33 failing for multiple examples
>>>>>> of:
>>>>>>
>>>>>> In file included from ../../third_party/unrar/src/crypt.cpp:1:
>>>>>> In file included from ../../third_party/unrar/src/rar.hpp:6:
>>>>>> ../../third_party/unrar/src/os.hpp:167:10: fatal error: 'asm/hwcap.h'
>>>>>> file not found
>>>>>> 167 | #include <asm/hwcap.h>
>>>>>> | ^~~~~~~~~~~~~
>>>>>> 1 error generated.
>>>>>>
>>>>>> (Note: electron31 and electron32 are still building.)
>>>>>>
>>>>>> It would seem appropriate to avoid wasting time on bad
>>>>>> build attempts as long as this is the case: while it is
>>>>>> not yet fixed, it likely should be marked as BROKEN_aarch64
>>>>>> in the Makefile involved.
>>>>>
>>>>>
>>>>> electron32 got the same sort of failures:
>>>>>
>>>>> 2.3.0/pulseaudio-16.1/src -DPA_MAJOR=16 -c ../../third_party/unrar/
>>>>> google/unrar_wrapper.cc -o obj/third_party/unrar/unrar/unrar_wrapper.o
>>>>> In file included from ../../third_party/unrar/google/unrar_wrapper.cc:13:
>>>>> In file included from ../../third_party/unrar/src/rar.hpp:6:
>>>>> ../../third_party/unrar/src/os.hpp:167:10: fatal error: 'asm/hwcap.h'
>>>>> file not found
>>>>> 167 | #include <asm/hwcap.h>
>>>>> | ^~~~~~~~~~~~~
>>>>> 1 error generated.
>>>>>
>>>>>
>>>>> Note: electron31 is still building.
>>>>>
>>>>>
>>>>> I'll also note that chromium got the same sort of error:
>>>>>
>>>>> In file included from ../../third_party/unrar/google/unrar_wrapper.cc:13:
>>>>> In file included from ../../third_party/unrar/src/rar.hpp:6:
>>>>> ../../third_party/unrar/src/os.hpp:167:10: fatal error: 'asm/hwcap.h'
>>>>> file not found
>>>>> 167 | #include <asm/hwcap.h>
>>>>> | ^~~~~~~~~~~~~
>>>>> 1 error generated.
>>>>>
>>>>>
>>>>> Note: ungoogled-chromium is still building, as is
>>>>> iridium-browser .
>>>>
>>>> By contrast:
>>>>
>>>> electron31 and iridium-browser built just fine.
>>>>
>>>> Note: ungoogled-chromium is still building.
>>>
>>> Thanks for the report. I agree that electron{32,33} should be marked as
>>> BROKEN_aarch64 until a patch for fixing the issue is provided.
>>>
>>> Unrar version 7 used by electron 32 and onward tries to include the
>>> header in question. Older version (v6) of unrar, which is in turn used
>>> by electron 31, does not.
>>>
>>> Best regards,
>>> Hiroki
>>>
>>>
>> Hi all,
>> I maintain archivers/libunrar and after seeing this, I just committed
>> a patch [1] to my port to fix this problem. The libunrar patches have
>> some additional guff to add openssl support that should not be
>> included for chromium-based projects, but the concept is basically the
>> same. Should be pretty easy to adapt.
>> [1]
>> https://cgit.freebsd.org/ports/commit/?id=96e53c0c65faa691e18c0a5558d8f445e6010a70
>
> Hi Jason,
>
> Thanks a lot for letting me know the commit. I will shortly prepare a patch
> for electron ports based on that.
FYI:
I'll note that, while chromium did not build to completion,
ungoogled-chromium-132.0.6834.159.pkg built just fine in
the same "bulk -a" run. In my original reporting, it had
not yet completed but I forgot to report the completion at
the time I noticed it.
===
Mark Millard
marklmi at yahoo.com
