apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
+1 LGTM
INLINE COMMENTS
> startup.cpp:275
> QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(pending,
> this);
> - QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this,
> &Startup::secondKDEDPhaseLoaded);
> + QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this,
> [this]() {emitResult();});
> QObject::connect(watcher, &QDBusPendingCallWatcher::finished, watcher,
> &QObject::deleteLater);
can't this be `&KJob::emitResult`?
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16231
To: davidedmundson, #plasma, apol
Cc: apol, broulik, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
