anthonyfieroni added inline comments.
INLINE COMMENTS
> startup.cpp:194
> + connect(phase1, &KJob::finished, this, [=]() {
> + ksmserver->setupShortcuts(); // done only here, because it needs
> kglobalaccel :-/
> + });
Can we delay it to finishStartup?
> startup.cpp:210
>
> -void Startup::autoStart0()
> +void Startup::upAndRunning( const QString& msg )
> {
It's unused, can we remove it?
> startup.h:39
> + void start() override;
> +private:
> };
Remove ?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D16231
To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart