zzag added inline comments.
INLINE COMMENTS
> desktop.cpp:73
> } else if (m_actions.count() > numDesktops) {
> - for (int i = numDesktops +1; i <= m_actions.count(); ++i) {
> - delete m_actions[i];
> - m_actions.remove(i);
> + for (int i = m_actions.count(); i <= numDesktops; --i) {
> + delete m_actions[i - 1];
Will this loop ever be executed?
Also, why not `delete m_actions.take(i - 1);`?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D15599
To: hein, mart, davidedmundson
Cc: zzag, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
