broulik added inline comments.
INLINE COMMENTS
> desktop.cpp:46
> +
> + if (!s_virtualDesktopInfo) {
> + delete s_virtualDesktopInfo;
`!s_instanceCount`
> desktop.cpp:65
>
> - //Is it either the first time or the desktop number changed?
> if (m_actions.count() < numDesktops) {
> for (int i = m_actions.count() + 1; i <= numDesktops; ++i) {
This codes doesn't take into account when the virtual desktop names change etc.
I think it should re-create the actions every time, and not try to be "smart"
by only changing the ones that are "superfluous" or "missing" as the names and
order inbetween could have changed
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D15599
To: hein, mart, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
