davidedmundson added a comment.
Also you can remove the lines
} else if (key == QByteArrayLiteral("X-KDE-ServiceTypes") || key ==
QByteArrayLiteral("ServiceTypes")) {
const auto services = deserializeList(value);
- for(const auto &service : services) {
- // some .desktop files still use the legacy ServiceTypes= key
- QString fileName = service.toLower().replace(QLatin1Char('/'),
QLatin1Char('-'))+QStringLiteral(".desktop");
- serviceTypes.addFile(fileName);
- }
from inside DesktopFileParser::convertToJson as we'll hae already done that
(I had written https://paste.kde.org/pipfub7bu last night, but wanted to
split that tokenisation out that you've done)
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4082
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, dfaure, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
