davidedmundson added inline comments.
INLINE COMMENTS
> desktopfileparser.cpp:541
> + lineNr=0;
> + df.close();
> + readUntilDesktopEntryGroup(df, src, lineNr);
We don't need to close
readUntilDesktopEntryGroup()
auto pos = dr.pos();
while() {
}
dr.seek(pos);
while() {
}
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D4082
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, davidedmundson, dfaure
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
