drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land.
In https://phabricator.kde.org/D3124#58077, @davidedmundson wrote: > In https://phabricator.kde.org/D3124#58026, @drosca wrote: > > > Sorry, I've noticed this one only after accepting the previous. > > This looks better, as long as it works without regressions. So, let's push the first fix to Plasma/5.8 and this one to master? > > > I'll do that if you want, but I'd rather not as it means we have something on 5.8 that isn't being tested by anyone. Alright, let's go only with this one. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D3124 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, drosca Cc: drosca, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas