drosca requested changes to this revision.
drosca added a reviewer: drosca.
drosca added a comment.
This revision now requires changes to proceed.
Sorry, I've noticed this one only after accepting the previous.
This looks better, as long as it works without regressions. So, let's push
the first fix to Plasma/5.8 and this one to master?
INLINE COMMENTS
> pulseaudio.cpp:42
> {
> + auto c = Context::instance();
> + c->ref();
Either don't create `c` variable here (as it is used only once), or also catch
it and use it from the lambda.
> pulseaudio.cpp:101
>
> +Context* AbstractModel::context() const
> +{
`Context *AbstractModel ...`
REPOSITORY
rPLASMAPA Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D3124
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, drosca
Cc: drosca, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
