----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128703/#review98453 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Aug. 18, 2016, 7:43 a.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128703/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 7:43 a.m.) > > > Review request for Plasma. > > > Bugs: 348254 and 367074 > https://bugs.kde.org/show_bug.cgi?id=348254 > https://bugs.kde.org/show_bug.cgi?id=367074 > > > Repository: plasma-desktop > > > Description > ------- > > Kdelibs4SharedConfig::syncConfigGroup() reads the settings from the > corresponding KF5 config files. > If we don't write them before, it will use the previous settings. > > Also fix Kdelibs4SharedConfig::syncConfigGroup() to read the settings from > the passed config file instead of always kdeglobals. > > > Diffs > ----- > > kcms/input/mouse.cpp 3dbda19 > kcms/migrationlib/kdelibs4config.h a2f4139 > > Diff: https://git.reviewboard.kde.org/r/128703/diff/ > > > Testing > ------- > > Change between single-click and double-click (or some other setting like > right-handed/left-handed) and apply. > The KDE4 settings are written correctly now, they are the same as for KF5. > > Before, the old settings (before clicking Apply) were saved to KDE4, the > Mouse settings in kcminputrc were not written at all. > > > Thanks, > > Wolfgang Bauer > >
