> On Aug. 17, 2016, 5:26 p.m., Martin Gräßlin wrote: > > kcms/input/mouse.cpp, line 761 > > <https://git.reviewboard.kde.org/r/128703/diff/1/?file=474492#file474492line761> > > > > isn't that too much? That will also sync unrelated settings in group > > "KDE", wouldn't it? > > Wolfgang Bauer wrote: > I supppose so, yes. > But this was in there before, I didn't change it, just move it.
oh right, didn't notice that. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128703/#review98435 ----------------------------------------------------------- On Aug. 17, 2016, 4:47 p.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128703/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 4:47 p.m.) > > > Review request for Plasma. > > > Bugs: 367074 > https://bugs.kde.org/show_bug.cgi?id=367074 > > > Repository: plasma-desktop > > > Description > ------- > > Kdelibs4SharedConfig::syncConfigGroup() reads the settings from the KF5 > config file. > If we don't write them before, it will use the previous settings. > > > Diffs > ----- > > kcms/input/mouse.cpp 3dbda19 > > Diff: https://git.reviewboard.kde.org/r/128703/diff/ > > > Testing > ------- > > Change between single-click and double-click and apply. > The KDE4 setting is written correctly now, it is the same as for KF5. > Before it was inverted, i.e. the previous one. > > > Thanks, > > Wolfgang Bauer > >