graesslin added a comment.
I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in FakeInputInterface. But it must be done somewhere - either in the library or by the user of the library. INLINE COMMENTS > fakeinput_interface.cpp:196 > + FakeInputDevice *d = device(resource); > + if (!d || !d->isAuthenticated()) { > + return; The isAuthenticated check is not verified in the autotest. That's the same with the other new methods. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, graesslin, Plasma, bshah Cc: bshah, graesslin, plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel